Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom logger format #19

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Mar 5, 2023

Reason for This PR

roadrunner-server/roadrunner#1376

Description of Changes

New parameter format under Logger configuration is added.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian
Copy link
Member

Hey @cv65kr 👋🏻
Sorry for the long response, was overloaded with other PRs 😢

Generally, this is a good idea, but let's make it Draft ATM, while we agree on the format and get some feedback from the users/creator of the ticket.

@rustatian rustatian self-requested a review March 11, 2023 20:53
@rustatian rustatian marked this pull request as draft March 11, 2023 20:53
@rustatian rustatian added the enhancement New feature or request label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: In Progress
2 participants