chore: do not set Endpoint and Headers

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
roadrunner-server · Feb 15, 2024 · 8d98ffe · 8d98ffe
1 parent a769566
commit 8d98ffe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/config.go b/config.go
@@ -73,11 +73,6 @@ func (c *Config) InitDefault(log *zap.Logger) {
 		log.Warn("service_version is deprecated, use resource.service_version instead")
 	}
 
-	if c.Endpoint == "" {
-		// otlp default
-		c.Endpoint = "127.0.0.1:4318"
-	}
-
 	if c.Exporter == jaegerExp {
 		log.Warn("jaeger exporter is deprecated, use OTLP instead: https://github.com/roadrunner-server/roadrunner/issues/1699")
 	}

diff --git a/plugin.go b/plugin.go
@@ -211,8 +211,14 @@ func httpOptions(cfg *Config) []otlptracehttp.Option {
 		options = append(options, otlptracehttp.WithURLPath(cfg.CustomURL))
 	}
 
-	options = append(options, otlptracehttp.WithEndpoint(cfg.Endpoint))
-	options = append(options, otlptracehttp.WithHeaders(cfg.Headers))
+	// if unset, OTEL will use the default one automatically
+	if cfg.Endpoint != "" {
+		options = append(options, otlptracehttp.WithEndpoint(cfg.Endpoint))
+	}
+
+	if len(cfg.Headers) > 0 {
+		options = append(options, otlptracehttp.WithHeaders(cfg.Headers))
+	}
 
 	return options
 }