This repository has been archived by the owner on May 31, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat(http): access logs and x-sendfile support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Update dependencies Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 67.48% 67.71% +0.22%
==========================================
Files 110 110
Lines 9233 9294 +61
==========================================
+ Hits 6231 6293 +62
Misses 2376 2376
+ Partials 626 625 -1
Continue to review full report at Codecov.
|
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
C-enhancement
Category: enhancement. Meaning improvements of current module, transport, etc..
D-driver
Driver for the RR plugin
P-HTTP
Plugin: HTTP
R-beta
Release: Nominated for backporting to the RR in the beta channel.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
closes: #9
closes: #34
Description of Changes
Add support for the access logs at
Info
log level.Fields:
method
- http method.remote_addr
- request remote address.bytes_sent
- content-length,http_host
- host.request
- request Query.time_local
- local time in Common Log Format.request_length
- request body with headers size (content-len + size of all headers) in bytes. Max allowed headers size for the RR is 1MB.request_time
- request processing time in seconds with a milliseconds resolution.status
- http response status.http_user_agent
- http user agenthttp_referer
- http referer✏️ Access logs turned off by default, to turn on, please, use the following field in the configuration:
X-Sendfile
header.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.