Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: hardcoded sampler-specific configuration for otel plugin #1918

Closed
1 task done
bazilmarkov opened this issue May 13, 2024 · 1 comment · Fixed by roadrunner-server/otel#61
Closed
1 task done
Assignees
Labels
B-bug Bug: bug, exception
Milestone

Comments

@bazilmarkov
Copy link

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

It appears that the OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG settings are not having any effect, and the Roadrunner otel plugin is still using the default always_on sampling method.

I have been attempting to use traceidratio with a default sampling rate of 1%, but have not been successful so far.

I have tried to configure it using the global environment variables mentioned on the relevant page, but it seems that the sampler is hardcoded to always be on, as per the code

Version (rr --version)

2024.1.1

How to reproduce the issue?

  1. Set up basic otel configuration paired with grpc plugin.
otel:
  resource:
    service_name: ${SERVICE}
    service_version: ${VERSION}
  insecure: true
  exporter: otlp
  endpoint: ${AGENT_HOST}:4318
  1. Set up the tracer and sampling rate different from the default always_on using env variables
    OTEL_TRACES_SAMPLER: 'traceidratio'
    OTEL_TRACES_SAMPLER_ARG: '0.01'
  1. Make 100 requests to the service.

Expected result: 1% of the spans sent
Current result: 100% of the spans sent

Relevant log output

No response

@rustatian
Copy link
Member

Fixed, release planned on this Thursday, May 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants