Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2024.1.2 #1921

Merged
merged 2 commits into from
May 16, 2024
Merged

release: v2024.1.2 #1921

merged 2 commits into from
May 16, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented May 16, 2024

Reason for This PR

  • Bugfix release cycle.

Description of Changes

🚀 v2024.1.2 🚀

Upcoming new JOBS driver: google-pub-sub:

  • 🔥: Currently in a polishing phase, the new plugin will be released as part of the v2024.2.0. Stay tuned! (thanks @cv65kr)

gRPC plugin:

  • 🐛: strip extra slashes when there is no package defined in the protofile: PR, (thanks @satdeveloping)

OTEL plugin:

RR core plugin:

  • 🐛: RR workers/reset commands don't respect default config values: BUG, (thanks @r4m-alexd)

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features

    • Introduced a new google-pub-sub JOBS driver.
  • Improvements

    • gRPC plugin now strips extra slashes when no package is defined in the protofile.
  • Bug Fixes

    • OTEL plugin resolves issues with hardcoded AlwaysSample samples.
    • RR core plugin ensures RR workers/reset commands respect default config values.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label May 16, 2024
@rustatian rustatian added this to the v2024.1.2 milestone May 16, 2024
@rustatian rustatian requested a review from wolfy-j May 16, 2024 19:21
@rustatian rustatian self-assigned this May 16, 2024
Copy link
Contributor

coderabbitai bot commented May 16, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The upcoming v2024.1.2 release introduces several key improvements and fixes. A new google-pub-sub JOBS driver has been added, enhancing message queuing capabilities. The gRPC plugin now properly handles extra slashes when no package is defined in the protofile. Additionally, the OTEL plugin resolves issues with hardcoded sampling, and the RR core plugin ensures that RR workers/reset commands respect default configuration values.

Changes

File(s) Change Summary
CHANGELOG.md Added summary for the upcoming v2024.1.2 release.
.../google-pub-sub Introduced a new google-pub-sub JOBS driver.
.../gRPC Updated to strip extra slashes when no package is defined in the protofile.
.../OTEL Fixed hardcoded AlwaysSample samples.
.../RR core Addressed issue where RR workers/reset commands don't respect default config values.

In fields of code where rabbits play,
New features hop in bright array.
With gRPC and OTEL's grace,
And workers reset in their place.
Pub-sub messages leap and bound,
In v2024.1.2, joy is found! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Out of diff range and nitpick comments (6)
CHANGELOG.md (6)

Line range hint 21-22: Correct the heading level and add a blank line after the heading.

- ### `gRPC` plugin:
+ ## `gRPC` plugin:

- - 🔥 Remove experimental status from the OTEL in `gRPC`, [PR](https://github.com/roadrunner-server/grpc/pull/133)
+ 
+ - 🔥 Remove experimental status from the OTEL in `gRPC`, [PR](https://github.com/roadrunner-server/grpc/pull/133)

Line range hint 24-25: Correct the heading level and add a blank line after the heading.

- ### `SDK`:
+ ## `SDK`:

- - 🔥 Additional debug logging for the `maxExecs` with `jitter`: [PR](https://github.com/roadrunner-server/sdk/pull/121) (thanks @Kaspiman)
+ 
+ - 🔥 Additional debug logging for the `maxExecs` with `jitter`: [PR](https://github.com/roadrunner-server/sdk/pull/121) (thanks @Kaspiman)

Line range hint 27-28: Correct the heading level and add a blank line after the heading.

- ### `HTTP` plugin:
+ ## `HTTP` plugin:

- - 🔥 Use `protobuf` encoded payloads to prevent field reordering and JSON escaped symbols.
+ 
+ - 🔥 Use `protobuf` encoded payloads to prevent field reordering and JSON escaped symbols.

Line range hint 36-37: Correct the heading level and add a blank line after the heading.

- ### `Kafka` driver:
+ ## `Kafka` driver:

- - 🔥 Support [TLS configuration](https://docs.roadrunner.dev/queues-and-jobs/kafka#configuration) (thanks @dkomarek)
+ 
+ - 🔥 Support [TLS configuration](https://docs.roadrunner.dev/queues-and-jobs/kafka#configuration) (thanks @dkomarek)

Line range hint 39-40: Correct the heading level and add a blank line after the heading.

- ### `SDK`:
+ ## `SDK`:

- - 🔥 Use a small random jitter to prevent the [Thundering herd problem](https://en.wikipedia.org/wiki/Thundering_herd_problem) when user uses `max_jobs` option and all the workers restarted at the same time. This feature is enabled automatically. (thanks @Kaspiman)
+ 
+ - 🔥 Use a small random jitter to prevent the [Thundering herd problem](https://en.wikipedia.org/wiki/Thundering_herd_problem) when user uses `max_jobs` option and all the workers restarted at the same time. This feature is enabled automatically. (thanks @Kaspiman)

Line range hint 32-33: Correct the heading level and add a blank line after the heading.

- ## Upgrade guide: [link](https://docs.roadrunner.dev/general/compatibility)
+ # Upgrade guide: [link](https://docs.roadrunner.dev/general/compatibility)

- ### `HTTP` plugin:
+ 
+ ## `HTTP` plugin:
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 06967c4 and 535cd19.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (2)
CHANGELOG.md (2)

Near line 27: Loose punctuation mark.
Context: ...drunner-server/grpc/pull/133) ### SDK: - 🔥 Additional debug logging for the `...


Near line 42: Loose punctuation mark.
Context: ...iguration) (thanks @dkomarek) ### SDK: - 🔥 Use a small random jitter to preve...

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@rustatian rustatian merged commit 0260a82 into master May 16, 2024
12 checks passed
@rustatian rustatian deleted the release/v2024.1.2 branch May 16, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant