release: v2024.1.3
#1936
release: v2024.1.3
#1936
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
rustatian
added
the
C-enhancement
WalkthroughIn version Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
6-6: Clarify the comma usage for better readability.Consider revising the sentence to avoid confusion and enhance clarity. Perhaps rephrasing to separate the cause of the confusion from the description of the feature might help.
Tools
LanguageTool
[formatting] ~6-~6: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...ocumented feature which caused confusion, because any configuration value might be automa...Markdownlint
6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[uncategorized] ~5-~5: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...NGELOG # 🚀 v2024.1.3 🚀 ###RR core: - 🔥: DeprecateRR_*env variables pr...
[formatting] ~6-~6: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...ocumented feature which caused confusion, because any configuration value might be automa...
[typographical] ~9-~9: It appears that a comma is missing. (DURING_THAT_TIME_COMMA)
Context: ...drunner-temporal/issues/522). With this change you may replace certificate on a Live s...
[uncategorized] ~23-~23: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...22.4. ## RoadRunner PHP: ###Worker: - 🔥: AddRR_VERSIONenv to theEnvi...
[uncategorized] ~53-~53: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...drunner-server/grpc/pull/133) ###SDK: - 🔥 Additional debug logging for the `...
[uncategorized] ~68-~68: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...iguration) (thanks @dkomarek) ###SDK: - 🔥 Use a small random jitter to preve...
Markdownlint
CHANGELOG.md
5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
31-31: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
47-47: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
26-26: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
23-23: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
31-31: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
34-34: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
37-37: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
40-40: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
47-47: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
50-50: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
53-53: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
62-62: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
65-65: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
29-29: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
45-45: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
58-58: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
16-16: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
19-19: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
24-24: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
32-32: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
35-35: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
38-38: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
41-41: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
48-48: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
51-51: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
54-54: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
63-63: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
66-66: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
Additional comments not posted (5)
CHANGELOG.md (5)
3-27: Ensure all user-facing changes are mentioned as per PR checklist.The CHANGELOG.md updates comprehensively cover the changes in the new release v2024.1.3, aligning with the PR objectives to include all user-facing changes.
Tools
LanguageTool
[uncategorized] ~5-~5: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...NGELOG # 🚀 v2024.1.3 🚀 ###RR core: - 🔥: DeprecateRR_*env variables pr...
[formatting] ~6-~6: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...ocumented feature which caused confusion, because any configuration value might be automa...
[typographical] ~9-~9: It appears that a comma is missing. (DURING_THAT_TIME_COMMA)
Context: ...drunner-temporal/issues/522). With this change you may replace certificate on a Live s...
[uncategorized] ~23-~23: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...22.4. ## RoadRunner PHP: ###Worker: - 🔥: AddRR_VERSIONenv to theEnvi...Markdownlint
5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
26-26: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
23-23: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
16-16: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
19-19: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
24-24: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
15-15: Correct heading level for consistency.- ### `Endure` container: + ## `Endure` container:Likely invalid or redundant comment.
Tools
Markdownlint
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
18-18: Correct heading level for consistency.- ### General: + ## General:Likely invalid or redundant comment.
Tools
Markdownlint
18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Correct heading level for consistency.- ### `Kafka` + ## `Kafka`Likely invalid or redundant comment.
Tools
Markdownlint
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Correct heading level for consistency.- ### `Temporal` plugin: + ## `Temporal` plugin:Likely invalid or redundant comment.
Tools
Markdownlint
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
Reason for This PR
Description of Changes
RR core:RR_*env variables prefix. This was an undocumented feature which caused confusion, because any configuration value might be automatically replaced (without using env in the configuration) with a matchingRR_*environment variable, PR.Temporalplugin:continue_as_new_suggestedfor the PHP Worker: PR.KafkamaxPollRecordsfrom 10k to 100, PR.Endurecontainer:General:
v1.22.4.RoadRunner PHP:
Worker:RR_VERSIONenv to theEnvironmentclass: PRLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit
New Features
continue_as_new_suggestedfor the PHP Worker in the Temporal plugin.RR_VERSIONenvironment variable to the RoadRunner PHP Worker.Deprecations
RR_*environment variable prefix in RR core.Improvements
maxPollRecordsin Kafka from 10,000 to 100.v1.22.4.Bug Fixes