Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log maxExecs with jitter after worker is started #121

Merged
merged 1 commit into from Apr 16, 2024

Conversation

Kaspiman
Copy link
Sponsor Contributor

@Kaspiman Kaspiman commented Apr 15, 2024

Reason for This PR

Log maxExecs + jitter for debug purpose

Description of Changes

Ai power?

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features

    • Added a method to retrieve the maximum number of executions allowed for a process.
  • Refactor

    • Updated streaming and cancellation terminology for clarity in process management.
    • Enhanced logging to include the maximum executions value when a worker is allocated.

Signed-off-by: Vladimir Plakhotnikov <embargo2710@gmail.com>
Copy link

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent updates in the codebase focus on enhancing logging and clarity in process management. Changes include improved logging for the max_execs parameter in the pool allocator and renaming a constant for better clarity in worker operations. Additionally, a method for fetching the maximum executions allowed has been added to the Process struct.

Changes

File Path Change Summary
pool/.../allocator.go Added logging for max_execs during worker allocation.
worker/.../worker.go Renamed constant for clarity and added MaxExecs() method.

🐰✨
In the land of code, where the bits align,
A rabbit hopped, leaving changes behind.
"Log and track, make all clear,
Stream and cancel, have no fear!"
With a twitch of a nose, a new commit shines. 🌟
🐰✨


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7f2b141 and ae82a46.
Files selected for processing (2)
  • pool/allocator.go (1 hunks)
  • worker/worker.go (2 hunks)
Files not reviewed due to errors (1)
  • (no review received)
Additional comments not posted (1)
pool/allocator.go (1)

40-40: Logging enhancement approved. This change improves visibility into worker allocation, aiding in debugging and operational transparency.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.19%. Comparing base (91b2b9c) to head (ae82a46).
Report is 31 commits behind head on master.

Files Patch % Lines
worker/worker.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   72.69%   73.19%   +0.50%     
==========================================
  Files          23       24       +1     
  Lines        2212     1649     -563     
==========================================
- Hits         1608     1207     -401     
+ Misses        553      394     -159     
+ Partials       51       48       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kaspiman Kaspiman requested a review from rustatian April 15, 2024 10:32
@Kaspiman
Copy link
Sponsor Contributor Author

Perhaps the Main Developer is waiting for me to merge this PR by myself...

Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Kaspiman 👍

p.s.: no merges w/o approve, thanks.

@rustatian rustatian merged commit 311d59e into roadrunner-server:master Apr 16, 2024
7 checks passed
@Kaspiman Kaspiman deleted the max_jobs_log branch April 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants