Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back into Roam42 #38

Closed
dvargas92495 opened this issue Jun 29, 2021 · 0 comments
Closed

Merge back into Roam42 #38

dvargas92495 opened this issue Jun 29, 2021 · 0 comments

Comments

@dvargas92495
Copy link
Collaborator

dvargas92495 commented Jun 29, 2021

This will be a tracker issue to make sure we cover all of the things before merging smartblocks V2 back into roam42. This will be done after release and will not be part of the project:

  • Roam42 loads smartblocks script from RoamJS instead of from Roam42
  • window.roam42.smartblocks globals functions point to window.roamjs.smartblocks globals
  • Workbench <> Smartblocks - Nuke the idea of and be able to infer whether we need a block or not.
  • Change default keystroke back to jj both in extension and in docs. uncomment 42setting
  • Reinsert (42)? into button text regex
  • Change roam42 docs to link straight to smartblocks extension and delete roam42/smartblocks pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant