Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detection for non-resources xml file to prevent errors #13

Merged
merged 4 commits into from Mar 17, 2017

Conversation

mariotaku
Copy link
Contributor

Hi, it's me again 馃樃 , thanks for this awesome plugin!

This PR adds detection for non-resources xml file, and hides menu entry for them.

For AndroidManifest.xml and so on:
image

For strings.xml, arrays.xml and so on:
image

@roana0229
Copy link
Owner

roana0229 commented Mar 16, 2017

Hi, thank you as always! 馃槃
I will confirm soon.

@roana0229
Copy link
Owner

I Compiled this branch. And not found XMLInputFactory.newFactory() method. 馃槩
I found XMLInputFactory.newInstance().
But, XMLInputFactory.newInstance() is deprecated.

I am using environment this.

IntelliJ IDEA 2016.3.5
Build #IC-163.13906.18, built on March 6, 2017
JRE: 1.8.0_112-release-408-b6 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

@mariotaku Please teach your environment and setting. 馃檹

@mariotaku
Copy link
Contributor Author

Sorry, maybe it's an incompatible method. I'll check tomorrow. How to print out our development environment by the way?

@roana0229
Copy link
Owner

roana0229 commented Mar 16, 2017

I'll check tomorrow

Thank you 馃槂

I copied this way.
IntelliJ IDEA Menu > About IntelliJ IDEA > Copy to Clipboard (show when hover mouse on environment)

@mariotaku
Copy link
Contributor Author

My environment seems identical

IntelliJ IDEA 2016.3.5
Build #IC-163.13906.18, built on March 6, 2017
JRE: 1.8.0_112-release-408-b6 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

...While project SDK is
Android Studio AI-143.2821654

@mariotaku
Copy link
Contributor Author

@roana0229 Done! I guess this problem was fixed, to make sure this works we could run it and try.

@roana0229
Copy link
Owner

馃憖 I will confirm tonight.

@roana0229
Copy link
Owner

Awesome 馃憤

@roana0229 roana0229 merged commit f3150ff into roana0229:master Mar 17, 2017
@roana0229 roana0229 mentioned this pull request Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants