-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#240 support s3 direct with ColumnQObjectStoreProvider #241
Conversation
63b7248
to
f027787
Compare
use datafusion::datasource::object_store::ObjectStoreProvider; | ||
use url::Url; | ||
|
||
use super::ColumnQObjectStoreProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houqp PR is ready for review, including both unit tests and integration tests
Thanks
Exciting stuff, thanks @jychen7 ! |
I think it's about time to create a new release since there are a lot of improvements added since the last one. @jychen7 do you have any major feature you plan to add before the release. |
@houqp no, I think it is good to create a release. |
What
part 1 of #240, also close #227
Why
before this PR, there is error about
Because it creates a new SessionContext and such context have no registry or provider for
s3
roapi/columnq/src/table/parquet.rs
Lines 35 to 36 in c0bff95
How
This PR adds ObjectStoreProvider to the "global" SessionContext and pass it down to
columnq/src/table/parquet.rs
For Reviewer
The PR is ready to review with