Simplify read database table code #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Sep 11, 2023
|
this is so much cleaner, thank you! |
houqp
reviewed
Sep 11, 2023
| .map_err(|e| ColumnQError::Database(e.to_string()))?; | ||
| Ok(datafusion::datasource::MemTable::try_new( | ||
| destination.arrow_schema(), | ||
| vec![destination.arrow().unwrap()], |
There was a problem hiding this comment.
instead of doing an unwrap here, we should propagate the error to the caller instead so we don't crash the server
There was a problem hiding this comment.
Yes thank you! I will make another PR to fix this, since the previous PR has already been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#286