Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK, I'm ready #301

Closed
littlegolden opened this issue May 22, 2020 · 12 comments
Closed

OK, I'm ready #301

littlegolden opened this issue May 22, 2020 · 12 comments
Assignees

Comments

@littlegolden
Copy link
Contributor

So what's next? 😃
Chinese language pack
Japanese language pack

@rob006
Copy link
Member

rob006 commented May 22, 2020

I added Simplified Chinese to Weblate. I'll add Japanese tomorrow if there will be no problems with Chinese.

To move this forward:

  1. Create an account at https://weblate.rob006.net/ - I'll grant you privileges to review translations. You can also start watching Flarum projects and configure your languages - you will get notifications when new string for translation will be detected.
  2. You can start review existing translations - some translations are missing, other may have some errors detected by automated tests from Weblate.
  3. Review and merge Initial export from Weblate littlegolden/flarum-lang-simplified-chinese#5
  4. I can configure bot to push changes from Weblate to your repo automatically, but you need to grant write access for @robbot006 user. You can do this in repository Settings > Manage access:
    54353167

@rob006 rob006 self-assigned this May 22, 2020
@rob006 rob006 added the enhancement New feature or request label May 22, 2020
@rob006
Copy link
Member

rob006 commented Jun 2, 2020

@littlegolden You've sent collaborate invitation to wrong account - it should be @robbot006 (I'm using separate bot account for these tasks).

littlegolden/flarum-lang-simplified-chinese#5 is still not merged (I could marge it myself now, but I prefer you merge it yourself after review - it is your repo after all, I don't want to mess anything ;)).

@littlegolden
Copy link
Contributor Author

Thank you so much ❤, I have a lot of lab reports to write these days and I will take some spare time to check my translation file for any omissions.

@rob006
Copy link
Member

rob006 commented Jun 2, 2020

Thank you so much heart, I have a lot of lab reports to write these days and I will take some spare time to check my translation file for any omissions.

No hurry, just avoid committing to https://github.com/Littlegolden/flarum-lang-simplified-chinese in the meantime, since it will generate nasty conflicts with littlegolden/flarum-lang-simplified-chinese#5.

@littlegolden
Copy link
Contributor Author

Is it possible to approve those "failed check" strings at once? One by one to eliminate the problem and click save to save those strings is almost killing me. 😂

@rob006
Copy link
Member

rob006 commented Jul 23, 2020

@littlegolden To be honest I don't know, because I never tried to blindly ignore these inspections (usually it is worth to take a look at them).

Also you don't need to click "save" button to apply this change - you can use "next" button in navigation after dismissing inspection (I have an impression that it works faster than "save").

7573a7cf

This was referenced Jul 25, 2020
@rob006
Copy link
Member

rob006 commented Jul 25, 2020

@littlegolden I imported Japanese language pack to Weblate, you should already have permissions to manage translations.

Same as for Chinese:

  1. Review and merge Initial export from Weblate littlegolden/flarum-lang-japanese#5
  2. Grant write access for @robbot006 for https://github.com/Littlegolden/flarum-lang-japanese repository (see OK, I'm ready #301 (comment)).

@rob006
Copy link
Member

rob006 commented Sep 28, 2020

@littlegolden You still need to grant write access for @robbot006 for https://github.com/Littlegolden/flarum-lang-japanese repository (see #301 (comment)) to enable sync for this repository.

@littlegolden
Copy link
Contributor Author

OMG, I forgot this

@rob006
Copy link
Member

rob006 commented Sep 29, 2020

Closing, since everything seems to set up. Feel free to comment here if you encounter any problems.

@rob006 rob006 closed this as completed Sep 29, 2020
@littlegolden
Copy link
Contributor Author

littlegolden commented Oct 6, 2020

Hi @rikusen0335, Japanese Translation has been moved to Weblate Translate Platform, you can sign up an account to continue contributing.

@rikusen0335
Copy link
Contributor

rikusen0335 commented Oct 6, 2020

Oh that's glad to hear that. Thank you for the information!

@rob006 rob006 added language-pack and removed enhancement New feature or request labels Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants