Refactor options storage #1
Conversation
| mv web_extension/shared/version.js.dev web_extension/shared/version.js | ||
| } | ||
|
|
||
| trap restore_version EXIT |
|
|
||
| cat << JS > web_extension/shared/version.js | ||
| // this file automatically updated at build time by bin/package | ||
| class Version { } |
There was a problem hiding this comment.
class Version {
static number = "v$version"
}?
There was a problem hiding this comment.
Docs say static properties must declared outside the class. Because reasons.
| Version.number = "v$version" | ||
| JS | ||
|
|
||
| pushd web_extension |
There was a problem hiding this comment.
I like to think of switching directories as a stack more than just cd -'ing
| 'use strict'; | ||
|
|
||
| async function fetchImage() { | ||
| let feed_url = options.feed.url |
There was a problem hiding this comment.
looks like a lot of these could be const'd
| document.querySelector('info by-line').appendChild( link(item.author.url, item.author.name) ) | ||
| document.querySelector('info venue').appendChild( link(item._meta.venue.url, item._meta.venue.name) ) | ||
| document.querySelector('info name').appendChild( | ||
| Builder.link(item.external_url, item.content_text) |
There was a problem hiding this comment.
I'm highly skeptical but also at this rate you'll have re-invented react or something soon 😂
There was a problem hiding this comment.
too heavyweight. Unfortunately the innerHTML = template thing doesn't work because it's not safe and things
| let hideIfChecked = (checkboxes, toggled_control) => { | ||
| let visible = false | ||
| checkboxes = [].concat(checkboxes) | ||
| checkboxes.forEach(function(box_id) { |
There was a problem hiding this comment.
stylistically, you're mixing arrow functions with non-arrows ¯\_(ツ)_/¯
There was a problem hiding this comment.
a truth. I learned how to arrow things this morning...
| } | ||
|
|
||
| async function read_storage(){ | ||
| current_storage = await browser.storage.sync.get() |
There was a problem hiding this comment.
where is current_storage ?
There was a problem hiding this comment.
just here..in the function...I guess
web_extension/shared/options.js
Outdated
| } | ||
|
|
||
| async read () { | ||
| let promise = browser.storage.sync.get() |
There was a problem hiding this comment.
| let promise = browser.storage.sync.get() | |
| const stored_options = await browser.storage.sync.get() | |
| [...] | |
| return stored_options |
but also is it .sync if its returning a promise?
There was a problem hiding this comment.
I did it this way because I want to return the promise up the chain, so I can await it elsewhere. I had a reason.
There was a problem hiding this comment.
And the deceptively named .sync is for configuration which is sync'd by the firefox browser
| this.clock_persistence = "Subtle" | ||
| this.info_persistence = "Subtle" | ||
| this.clock_flash = false | ||
| this.date_format = "good" |
| class FeedOptions extends OptionsSubset { | ||
| constructor () { | ||
| super() | ||
| this.url = "https://robacarp.github.io/photographic_start/feed.json" |
There was a problem hiding this comment.
Maybe make this an option too! 🎉 🐠
There was a problem hiding this comment.
Well technically, it is an option now. You just have to devtools it to change it. But whatever is stored in the browser.sync storage will prevail.
robacarp
force-pushed
the
refactor_options
branch
from
a29aeac
to
c0c82b0
Compare
No description provided.