Skip to content

Commit

Permalink
check-es-compat: Disallowed Eslint inline config comments to work wit…
Browse files Browse the repository at this point in the history
…h unminified code. (#102)

* check-es-compat: Disallowed Eslint inline config comments to work with unminified code.

* Make prettier apply to mjs file

* Fix indentation to spaces

* Update comment

* Clarify comment

---------

Co-authored-by: Robat Williams <robatwilliams@gmail.com>
  • Loading branch information
brabeji and robatwilliams committed Mar 8, 2024
1 parent 15b259f commit abb3e69
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"scripts": {
"check": "npm-run-all --parallel check:*",
"check:lint": "eslint --no-eslintrc --config=.eslintrc.json **/*.{js,mjs}",
"check:prettier": "prettier --check **/*.{js,json,md}",
"check:prettier": "prettier --check **/*.{js,json,md,mjs}",
"ci": "npm-run-all check test",
"postinstall": "lerna bootstrap",
"test": "lerna run test"
Expand Down
3 changes: 2 additions & 1 deletion packages/check-es-compat/bin/cli.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ if (args.length === 0) {

async function execute(files) {
const eslint = new ESLint({
// Ignore any config files
// Ignore any config; it's for target's own linter setup rather than this tool.
useEslintrc: false,
ignore: false,
allowInlineConfig: false,

baseConfig: {
plugins: ['ecmascript-compat'],
Expand Down

0 comments on commit abb3e69

Please sign in to comment.