Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error detected but no issues #53

Closed
susnux opened this issue Jan 6, 2023 · 3 comments · Fixed by #54
Closed

Error detected but no issues #53

susnux opened this issue Jan 6, 2023 · 3 comments · Fixed by #54
Labels
bug Something isn't working

Comments

@susnux
Copy link

susnux commented Jan 6, 2023

When running check-es-compat it reports:

dist/registry.js
  10:50  error  ES2020 optional chaining is forbidden  ecmascript-compat/compat
  11:50  error  ES2020 optional chaining is forbidden  ecmascript-compat/compat

✖ 2 problems (2 errors, 0 warnings)

No issues found. Files are compatible with the target runtimes.

So there are 2 errors but no issues found? The return code is also 0 ("ok")

@robatwilliams robatwilliams added the bug Something isn't working label Jan 6, 2023
@robatwilliams
Copy link
Owner

Thanks.

Problem - in cli.mjs, we get returned a LintResult[] but we're interrogating it for the error count as if it were a single LintResult.

@robatwilliams
Copy link
Owner

robatwilliams commented Jan 6, 2023

Caused by #37

In the old CLIEngine, a report object with various properties including a results array and a total errorCount were returned. The replacement ESLint just returns the results.

When I did the work, I renamed the variable and changed the pass-down to the formatter, but missed the errorCount.

@robatwilliams
Copy link
Owner

Released in https://github.com/robatwilliams/es-compat/releases/tag/v2.2.1

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants