Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for sending UDP multicast on IPv6 #746

Merged
merged 1 commit into from Oct 30, 2020
Merged

Fix for sending UDP multicast on IPv6 #746

merged 1 commit into from Oct 30, 2020

Conversation

dsmurfin
Copy link
Contributor

No description provided.

@dsmurfin
Copy link
Contributor Author

@chrisballinger This PR implements the changes from #239 but with no conflicts, and some slightly tweaked conventions to match the rest of the repo. Would be great if this could be merged into Master.

chrisballinger
chrisballinger approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your persistence on this one! Would be great if this could be accompanied by a unit test, but I think this is sufficient for now.

@chrisballinger chrisballinger merged commit 36ecfd0 into robbiehanson:master Oct 30, 2020
@chrisballinger chrisballinger mentioned this pull request Oct 30, 2020
Closed
@dsmurfin
Copy link
Contributor Author

Thanks @chrisballinger I will look to add a unit test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisballinger chrisballinger chrisballinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsmurfin @chrisballinger