Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting duration when using comfort mode #10

Merged
merged 3 commits into from Jan 28, 2023

Conversation

robbinjanssen
Copy link
Owner

What does it do?

set_regulation_mode now supports a parameter for duration (in minutes), only works for comfort mode.

@robbinjanssen robbinjanssen added the new-feature New features or options. label Jan 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34de3a5) compared to base (483f249).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          249       251    +2     
  Branches        36        36           
=========================================
+ Hits           249       251    +2     
Impacted Files Coverage Δ
ojmicroline_thermostat/const.py 100.00% <100.00%> (ø)
ojmicroline_thermostat/ojmicroline.py 100.00% <100.00%> (ø)
...roline_thermostat/requests/update_group_request.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robbinjanssen robbinjanssen merged commit f161961 into main Jan 28, 2023
@robbinjanssen robbinjanssen deleted the rja/add-duration branch January 28, 2023 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants