Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up repository, github actions and linting, remove Python 3.9 support #206

Merged
merged 9 commits into from Feb 12, 2024

Conversation

robbinjanssen
Copy link
Owner

@robbinjanssen robbinjanssen commented Feb 8, 2024

What does it do?

  • This was long due, but replace github actions and linters with new standards.
  • Use renovate instead of dependabot
  • Breaking: Remove support for Python 3.9, add support for 3.12

Clean up repository and code

Add missing dependencies

Fix commit
@robbinjanssen robbinjanssen added the breaking-change A breaking change for existing users. label Feb 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dae6cc0) 100.00% compared to head (712e1e2) 100.00%.
Report is 161 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #206    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            9         9            
  Lines          251       353   +102     
  Branches        36        55    +19     
==========================================
+ Hits           251       353   +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbinjanssen
Copy link
Owner Author

@adamjernst mind testing this with your thermostat? And maybe also against your updated HA implementation?

Would be greatly appreciated!

@adamjernst
Copy link
Contributor

@adamjernst mind testing this with your thermostat? And maybe also against your updated HA implementation?

Would be greatly appreciated!

Will do!

@adamjernst
Copy link
Contributor

@robbinjanssen I can confirm that with this patch, your changes work great with WG4-model thermostats. Merge this and I'll get to work polishing up my PR!

@robbinjanssen robbinjanssen merged commit 0648818 into main Feb 12, 2024
23 checks passed
@robbinjanssen robbinjanssen deleted the rja/clean-up-repo branch February 12, 2024 08:23
@robbinjanssen
Copy link
Owner Author

@adamjernst awesome! Tagged as v3.0.0!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants