-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vacation mode for WG4-series thermostats #217
Conversation
I mistakenly believed that vacation mode was not actually used for WG4-series thermostats. It is! This PR correctly parses vacation fields. It still does not support scheduling vacation mode (just like WD5-series thermostats).
@@ -51,6 +51,10 @@ This object represents the current state of a thermostat. | |||
| `manual_temperature` | integer | If the regulation mode is set to manual mode, the thermostat will target this temperature. | | |||
| `comfort_temperature` | integer | If the regulation mode is set to comfort mode, the thermostat will target this temperature. | | |||
| `comfort_end_time` | datetime | If the regulation mode is set to comfort mode, it will end at this time. | | |||
| `vacation_mode` | boolean | If true then the thermostat is set to `vacation_temperature` from `vacation_begin_time` to `vacation_end_time`. If false, then no vacation is in progress or scheduled. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vacation_mode
is a confusing name since we also have regulation_mode
. The API calls this VacationEnabled
which is more accurate.
This boolean does not indicate whether we are currently in the vacation regulation mode. It indicates whether a vacation is currently scheduled, regardless of whether it begins in the past or future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I tried to update this documentation to make it a bit clearer.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to change it to vacation_enabled
thats fine with me, makes more sense :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, that's a backwards incompatible change so I figure we should leave it for the next major version bump.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 352 353 +1
Branches 55 55
=========================================
+ Hits 352 353 +1 ☔ View full report in Codecov by Sentry. |
Tagged as v3.1.0! |
I mistakenly believed that vacation mode was not actually used for WG4-series thermostats. It is!
This PR correctly parses vacation fields. It still does not support scheduling vacation mode (just like WD5-series thermostats).