New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to Python 3.9 #231
Conversation
@snoack what is the reason you still would like support for python 3.9 and 3.10? :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 353 354 +1
Branches 55 55
=========================================
+ Hits 353 354 +1 ☔ View full report in Codecov by Sentry. |
In my case specifically, I'd like to use this library on Debian Bullseye which come with no newer than Python 3.9. |
Cool, how do you use the package there? Did you build a simple app on top of it? I think I want to keep the main branch python = "^3.11", however I'm open for a |
I was hoping to just install the package from PyPI once this PR has been merged and released. FWIW, this is the first package I came across that no longer supports Python 3.9. I'd understand if supporting older Python versions would impair the code quality, maintainability, performance, or features as you cannot use more modern Python features. But I don't see this being the case here. All it would take to support Python 3.9 here would be:
In fact it seems less of a maintenance burden to just merge those changes into the main branch than maintaining a separate branch for Python 3.9 support. But it's your call. |
I understand your reasoning, and mostly agree. I just created this library for my Home Assistant integration and it no longer uses python 3.9, thats why I bumped 😀 I'll merge this PR and release it!👍🏻 |
@snoack whoops, can you maybe update from |
Done. |
Thanks! Tagged as v3.1.1 :) |
No description provided.