Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to Python 3.9 #231

Merged
merged 1 commit into from Mar 1, 2024
Merged

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Feb 26, 2024

No description provided.

@robbinjanssen robbinjanssen added the refactor Improvement of existing code, not introducing new features. label Feb 27, 2024
@robbinjanssen
Copy link
Owner

@snoack what is the reason you still would like support for python 3.9 and 3.10? :)

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b897729) to head (61491c2).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          353       354    +1     
  Branches        55        55           
=========================================
+ Hits           353       354    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoack
Copy link
Contributor Author

snoack commented Feb 27, 2024

In my case specifically, I'd like to use this library on Debian Bullseye which come with no newer than Python 3.9.

@robbinjanssen
Copy link
Owner

Cool, how do you use the package there? Did you build a simple app on top of it?

I think I want to keep the main branch python = "^3.11", however I'm open for a python-39 branch (and tag them as such), the problem is that it wont receive (regularly) dependency updates. Is that okay for you?

@snoack
Copy link
Contributor Author

snoack commented Feb 29, 2024

I was hoping to just install the package from PyPI once this PR has been merged and released. FWIW, this is the first package I came across that no longer supports Python 3.9.

I'd understand if supporting older Python versions would impair the code quality, maintainability, performance, or features as you cannot use more modern Python features. But I don't see this being the case here. All it would take to support Python 3.9 here would be:

  • Using datetime.timezome.utc instead of datetime.UTC.
  • Using asyncio.TimeoutError instead TimeoutError
  • Importing Self from typing_extensions instead of typing.

In fact it seems less of a maintenance burden to just merge those changes into the main branch than maintaining a separate branch for Python 3.9 support. But it's your call.

@robbinjanssen
Copy link
Owner

I understand your reasoning, and mostly agree. I just created this library for my Home Assistant integration and it no longer uses python 3.9, thats why I bumped 😀

I'll merge this PR and release it!👍🏻

@robbinjanssen robbinjanssen added the dependencies Upgrade or downgrade of project dependencies. label Feb 29, 2024
@robbinjanssen
Copy link
Owner

robbinjanssen commented Feb 29, 2024

@snoack whoops, can you maybe update from main and fix/commit the lock file?

@snoack
Copy link
Contributor Author

snoack commented Feb 29, 2024

Done.

@robbinjanssen robbinjanssen merged commit c9fc48c into robbinjanssen:main Mar 1, 2024
16 checks passed
@robbinjanssen
Copy link
Owner

Thanks! Tagged as v3.1.1 :)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants