Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle Barnet council cookies message #727

Merged
merged 1 commit into from
May 24, 2024

Conversation

OliverCullimore
Copy link
Collaborator

Fix accepting cookies before entering postcode

@OliverCullimore OliverCullimore added bug Something isn't working python Pull requests that update Python code labels May 19, 2024
@OliverCullimore
Copy link
Collaborator Author

@robbrad also failing on this one where I've only added a few lines which is odd

@OliverCullimore
Copy link
Collaborator Author

Council tests failing with a "The currently activated Python version 3.10.12 is not supported by the project (>=3.11)." error.

Unable to see a reason for this error as behave.yml is using 3.11 and 3.12 now.

@OliverCullimore
Copy link
Collaborator Author

@robbrad Looks like it was present in another recent PR too https://github.com/robbrad/UKBinCollectionData/actions/runs/9138162537/job/25128988718#step:9:14 but either now we've removed the line caching poetry or due to upping the min python version it's escalated it from a warning to an error.

@OliverCullimore
Copy link
Collaborator Author

We've also dropped from 152 test cases to 44 https://robbrad.github.io/UKBinCollectionData/3.12/

@robbrad
Copy link
Owner

robbrad commented May 19, 2024

We've also dropped from 152 test cases to 44 https://robbrad.github.io/UKBinCollectionData/3.12/

Thats because it only tests the councils that changed :)

@robbrad robbrad merged commit daf4f48 into robbrad:master May 24, 2024
6 of 8 checks passed
@OliverCullimore OliverCullimore deleted the fix-barnet-council branch May 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants