Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit ce607d3fcb4c730c991563b4c62725cd89ce0ced breaks "tab" functionality #3670

Closed
Marco-Lindsay opened this issue Mar 5, 2015 · 5 comments · Fixed by #4093
Closed

Commit ce607d3fcb4c730c991563b4c62725cd89ce0ced breaks "tab" functionality #3670

Marco-Lindsay opened this issue Mar 5, 2015 · 5 comments · Fixed by #4093

Comments

@Marco-Lindsay
Copy link

No description provided.

@apjanke
Copy link
Contributor

apjanke commented Mar 7, 2015

Can you be more specific? What tab functionality – autocompletion? What's broken about it?

What operating system are you on, and what oh-my-zsh plugins do you have enabled?

@apjanke
Copy link
Contributor

apjanke commented Jun 26, 2015

Here's the commit: ce607d3
Doesn't look like it's part of a PR.

Sounds like you're talking about the tab() function inside the osx plugin. I don't know that this commit itself broke it. I undid the commit locally, and it still didn't work. New tabs opened with tab would have the cd ... command sitting there on the command line, but not executed. Is that what you're seeing?

screen shot 2015-06-26 at 1 06 20 am

When was the last time this actually worked for you?

I think the issue might be that the trailing semicolon in the $command string; it seems to cause iTerm to not execute it.

@apjanke
Copy link
Contributor

apjanke commented Jul 3, 2015

I put in a fix for this, #4093. Could you give it a try?

@Marco-Lindsay
Copy link
Author

That fixes the issue that I was referencing which was the "tab" functionality that is part of the OSX plugin stopped working on my system after the referenced commit.

@apjanke
Copy link
Contributor

apjanke commented Jul 3, 2015

Cool. Do you mind giving a "+1" comment on the PR itself? That will help it get merged sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants