Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Vim’s Dumb Terminal #207

Closed
wants to merge 1 commit into from

Conversation

sorin-ionescu
Copy link
Contributor

Do not override environmental variables declared in .zshenv or in /custom/.

Don't do this.

export LSCOLORS="Gxfxcxdxbxegedabagacad"

Always do this.

[[ -z "$LSCOLORS" ]] && export LSCOLORS=“Gxfxcxdxbxegedabagacad”

Other changes when a dumb terminal is detected:

  1. Disables colours.
  2. Loads /custom/ last to disable plugin colouring.
  3. Disables custom completion styles. Though, It would be best to turn completion off completely.
  4. Disables term support.

Vim Screen Shot

@robbyrussell
Copy link
Member

Apologies for the delay on this. It's not a clean merge at the moment, would you mind quickly updating those conflicts and re-submit?

@sorin-ionescu
Copy link
Contributor Author

No, I don't mind, but I propose an alternative. I've been working on #377, which has this incorporated as well as many other changes. Once I push these changes onto my fork on GitHub, you and the community can review it then backport what you like in one swoop.

@robbyrussell
Copy link
Member

Going to close this one as you're working on #377

Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
… reserved words should be a command word".
Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
Dannyzen pushed a commit to Dannyzen/oh-my-zsh that referenced this pull request Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants