Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If $OSTYPE starts with darwin, then use 'echo'. Otherwise use 'echo -e' #609

Closed
wants to merge 1 commit into from
Closed

If $OSTYPE starts with darwin, then use 'echo'. Otherwise use 'echo -e' #609

wants to merge 1 commit into from

Conversation

jedahan
Copy link

@jedahan jedahan commented Sep 14, 2011

Tested on Ubuntu and OSX

@jedahan
Copy link
Author

jedahan commented Sep 14, 2011

#602 does not work on ubuntu - no colors showed up
#571 does not work on ubuntu - print behaves differently
#555 looks good, as it doesn't need to check an env variable

My patch retains the current behavior exactly on any non-osx system. #555 is a good alternative. Pick your poison!

@ghost
Copy link

ghost commented Sep 14, 2011

Nice alternative to #555. More minimal of a change.

@jedahan
Copy link
Author

jedahan commented Dec 18, 2011

closing since #708 was merged

@jedahan jedahan closed this Dec 18, 2011
@sorin-ionescu sorin-ionescu mentioned this pull request Jan 26, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jedahan