Fix for issue #4 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes 2 related bugs, when sending getStatement API calls. First SCA header fields were only added to POST requests, but getStatement is a GET and needs SCA depending on account country. And SCA->path doesn't contain the required GET parameters, such as currency.
|
Thanks for the proposed changes. Can you expand on this: " might have broke some other functions" Can you please run this: ... with your changes and confirm all works. Thanks Rob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've tried to fix issue #4, I might have broke some other functions, with replacing $this->SCA in the last line. I'm not aware why you were using the URL returned in the json instead of the original URL.
PS:
Thanks for the class.