Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported GHC 8.8.1 #16

Merged
merged 1 commit into from Sep 11, 2022
Merged

Supported GHC 8.8.1 #16

merged 1 commit into from Sep 11, 2022

Conversation

asr
Copy link
Contributor

@asr asr commented Aug 20, 2019

GHC 8.8.1-rc1 was announced. In this PR I fixed the compilation with this version of GHC.

Blocking agda/agda#3725.

@asr asr mentioned this pull request Aug 20, 2019
@robdockins
Copy link
Owner

I think turning fail into error isn't the right fix in the majority of these cases. We probably actually want to turn most of the functions with a Moand constraint into an Alternative constraint instead and use empty instead of fail. I think this more accurately captures the original intent of the API.
In particular, in the (common, I suspect) case that the container type is Maybe it would continue to return Nothing in cases where elements are not found instead of going to error.

What do you think?

@nad
Copy link
Contributor

nad commented Sep 5, 2019

Another option would be to use MonadFail.

All changes were required by the MonadFail proposal.
@asr
Copy link
Contributor Author

asr commented Sep 6, 2019

Another option would be to use MonadFail.

This was my first try but I had some problems. Now, I could fix the problems based on the new module Agda/Utils/Fail.hs (thanks @UlfNorell). Note that I updated (force-pushed) the PR.

@robdockins
Copy link
Owner

This looks like a better fix to me. I'll work on finding some time soon (this weekend probably) to merge this and put up a new release.

felixonmars added a commit to felixonmars/edison that referenced this pull request Jun 19, 2021
The change is according to https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#unsafecoerce and should be backwards-compatible.

This applies on top of robdockins#16 and fixes robdockins#17
@robdockins robdockins merged commit 6a645b2 into robdockins:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants