-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression introduced in sorting code (pull #187) - narrow note list no longer sorted #204
Comments
Hi. |
code (pull robert7#187) - narrow note list no longer sorted robert7#204
Fixed by #207. |
Just built the develop branch, it's fixed indeed. Thanks a lot! |
code (pull robert7#187) - narrow note list no longer sorted robert7#204
Expected vs. actual behavior
I use the "narrow note list" and sort notes through View -> Sort notes by -> Date Updated. This has worked perfectly until 2.1.6, and has been broken in every version since 2.1.7.
Steps to reproduce the problem
Specifications
Running nixnote2 on Linux (Fedora 38), reproduced this behavior both using the Fedora copr package and by building from source.
I looked at the changes introduced in 2.1.7 (since this is where the problem appears). In 2.1.7, this issue is closed: #156 ("editor fonts and sorting notes").
Which is fixed by this pull request: https://github.com/robert7/nixnote2/pull/187/commits
Which contains this commit: 4fb6706
If I undo this commit (i.e. comment out the sorting code and add "this->setSortingEnabled(false);" again), then recompile, the regression is no longer there for me.
I don't know what the correct fix is, but if I read issue #156 correctly it seems that this commit fixed a sorting issue in "wide note list" mode, but as a side effect breaks sorting in "narrow note list".
Thanks,
Ludovic
The text was updated successfully, but these errors were encountered: