Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting Table generates incorrect HTML #27

Closed
aryadas98 opened this issue Oct 3, 2018 · 4 comments
Closed

Inserting Table generates incorrect HTML #27

aryadas98 opened this issue Oct 3, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@aryadas98
Copy link

aryadas98 commented Oct 3, 2018

Expected Behavior

Inserting a table should produce the HTML:

<table style="..."><tbody>...</tbody></table>

Actual Behavior

This HTML is produced:

<table style="..." <tbody=""><tbody>...</tbody></table>

This HTML is incorrect and produces errors while syncing.

Steps to reproduce the problem:

  1. Make a new note.
  2. Insert a table

Specifications

Version used: v2.1.0-beta-3

Workaround

Manually edit the HTML.

@robert7
Copy link
Owner

robert7 commented Oct 3, 2018

hmm it seems, you are right. i'll fix it
i did not notice before, as normally the markup is fixed by "tidy" .. so you see, in my case I inserted 2 tables and the note was synced OK (and the markup is OK now)

screen_20181003_03

@robert7 robert7 added the bug Something isn't working label Oct 3, 2018
@aryadas98
Copy link
Author

The sync issue was happening on baumgarr/nixnote2. So I thought it would happen here as well. Thanks for fixing it!

@robert7
Copy link
Owner

robert7 commented Oct 4, 2018

The sync issue was happening on baumgarr/nixnote2...

...ah OK. The v2.1 has much improved the html cleanup (not perfect, but quite better). So chance of automatic cleanup is much higher here. But I'll fix the underlying issue of the incorrect html.

@robert7
Copy link
Owner

robert7 commented Oct 11, 2018

@aryadas98 this should be fixed in version 2.1.0-beta4h
you can test it using the latest development AppImage https://github.com/robert7/nixnote2/releases/tag/continuous-develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants