Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefixing functionality #2

Closed
robertDurst opened this issue Jun 19, 2019 · 9 comments
Closed

Add prefixing functionality #2

robertDurst opened this issue Jun 19, 2019 · 9 comments
Assignees
@charlie-wasp
Labels
help wanted Extra attention is needed

Comments

@robertDurst
Copy link
Owner

No description provided.

@robertDurst robertDurst added the help wanted Extra attention is needed label Jun 19, 2019
@charlie-wasp
Copy link
Contributor

I would like to help with it 🙋‍♂

@robertDurst
Copy link
Owner Author

Awesome! Let me know if you run into any trouble or need some help figuring out where to begin?

@charlie-wasp
Copy link
Contributor

At the moment I'm trying to update dependencies and build the project 😅 Because some dependencies were yanked from crates.io, and in the current versions APIs were changed

@robertDurst
Copy link
Owner Author

Oh my, sorry about that! Has been a few days... or well months since I updated the dependencies.

@robertDurst
Copy link
Owner Author

Any api changes breaking change significant?

@charlie-wasp
Copy link
Contributor

I believe, no, just some permutations in rand crate's modules. I'll try to fix that and open PR

@charlie-wasp
Copy link
Contributor

Some API has been changed, actually, but nothing massive. Here is PR — #3

@robertDurst
Copy link
Owner Author

Thanks for that! Looks good, merged and opened an issue to update the crate version and push to crates.io which I will tackle tonight.

Fun fact, this is the most downloaded Stellar crate now...

@charlie-wasp charlie-wasp mentioned this issue Aug 5, 2019
Merged
@robertDurst
Copy link
Owner Author

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlie-wasp charlie-wasp

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlie-wasp @robertDurst