Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for release 0.1.6 #8

Merged
merged 12 commits into from
Jul 20, 2023
Merged

Prep for release 0.1.6 #8

merged 12 commits into from
Jul 20, 2023

Conversation

robertbetts
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 90.92% and project coverage change: -1.97 ⚠️

Comparison is base (e4d4f4c) 98.61% compared to head (1c6f536) 96.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   98.61%   96.64%   -1.97%     
==========================================
  Files          26       30       +4     
  Lines        1804     2116     +312     
==========================================
+ Hits         1779     2045     +266     
- Misses         25       71      +46     
Impacted Files Coverage Δ
src/openid_whisperer/main.py 100.00% <ø> (ø)
src/openid_whisperer/utils/user_info_ext.py 100.00% <ø> (ø)
tests/test_common_utils.py 100.00% <ø> (ø)
tests/conftest.py 80.95% <71.21%> (-19.05%) ⬇️
src/openid_whisperer/utils/test_utils.py 78.37% <78.37%> (ø)
src/openid_whisperer/openid_interface.py 91.66% <89.47%> (-2.73%) ⬇️
src/openid_whisperer/openid_blueprint.py 98.36% <90.24%> (-1.64%) ⬇️
tests/test_on_behalf_of_flow.py 92.10% <92.10%> (ø)
src/openid_whisperer/utils/token_store.py 97.61% <92.59%> (-2.39%) ⬇️
src/openid_whisperer/config.py 100.00% <100.00%> (+1.72%) ⬆️
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Enhanced unit test fixtures for improved consistency of criteria
More consistent treatment of client_secret, client secret can be blank where client_assertion is not used.
when used, client_assertion must ve a valid JWT however, the signature is deliberately not checked
Version bump to 0.1.6
@robertbetts
Copy link
Owner Author

A range of improvements bundled into 0.1.6
JWT client assertions
on-behalf of flow

@robertbetts robertbetts merged commit 3a1ee25 into main Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants