Allow all tasks to run in Docker.

README.md

@@ -43,7 +43,7 @@ cntlm_download_mirror: netcologne.dl.sourceforge.net
 cntlm_username: changeme
 cntlm_password: changeme
 cntlm_domain: example.com
-cntlm_proxy: changeme.example.com
+cntlm_proxy: changeme.example.com:3128
 
 # To what port should CNTLM listen?
 cntlm_listen: 3128
@@ -57,6 +57,11 @@ cntlm_noproxy: localhost
 # To update all packages installed by this roles, set `cntlm_package_state` to `latest`.
 cntlm_package_state: present
 
+# Some Docker containers do not allow managing services, rebooting and writing
+# to some locations in /etc. The role skips tasks that will typically fail in
+# Docker. With this parameter you can tell the role to -not- skip these tasks.
+cntlm_ignore_docker: yes
+
 ```
 
 Requirements
@@ -118,6 +123,9 @@ To test this role locally please use [Molecule](https://github.com/metacloud/mol
 pip install molecule
 molecule test
 ```
+
+To test on Amazon EC2, configure [~/.aws/credentials](https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html) and `export AWS_REGION=eu-central-1` before running `molecule test --scenario-name ec2`.
+
 There are many specific scenarios available, please have a look in the `molecule/` directory.
 
 Run the [ansible-galaxy[(https://github.com/ansible/galaxy-lint-rules) and [my](https://github.com/robertdebock/ansible-lint-rules) lint rules if you want your change to be merges:

defaults/main.yml

@@ -27,3 +27,8 @@ cntlm_noproxy: localhost
 
 # To update all packages installed by this roles, set `cntlm_package_state` to `latest`.
 cntlm_package_state: present
+
+# Some Docker containers do not allow managing services, rebooting and writing
+# to some locations in /etc. The role skips tasks that will typically fail in
+# Docker. With this parameter you can tell the role to -not- skip these tasks.
+cntlm_ignore_docker: yes

handlers/main.yml

@@ -6,7 +6,7 @@
   notify:
     - restart software
   when:
-    - ansible_virtualization_type != "docker"
+    - ansible_virtualization_type != "docker" or cntlm_ignore_docker
 
 - name: configure cntlm
   command: ./configure
@@ -32,4 +32,4 @@
     name: cntlm
     state: restarted
   when:
-    - ansible_virtualization_type != "docker"
+    - ansible_virtualization_type != "docker" or cntlm_ignore_docker

molecule/alpine-edge/molecule.yml

@@ -13,6 +13,10 @@ platforms:
     command: sh -c "while true ; do sleep 1 ; done"
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/alpine-latest/molecule.yml

@@ -13,6 +13,10 @@ platforms:
     command: sh -c "while true ; do sleep 1 ; done"
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/archlinux/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: base/archlinux
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/centos-6/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: centos:6
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/centos-latest/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: centos:latest
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/debian-latest/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: debian:latest
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/debian-stable/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: debian:stable
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/debian-unstable/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: debian:unstable
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/default/molecule.yml

@@ -42,6 +42,10 @@ platforms:
     image: ubuntu:latest
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
   config_options:

molecule/fedora-latest/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: fedora:latest
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/fedora-rawhide/molecule.yml

@@ -14,6 +14,10 @@ platforms:
       url: registry.fedoraproject.org
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/opensuse-leap/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: opensuse:leap
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/opensuse-tumbleweed/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: opensuse:tumbleweed
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/ubuntu-artful/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: ubuntu:artful
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/ubuntu-devel/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: ubuntu:devel
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

molecule/ubuntu-latest/molecule.yml

@@ -12,6 +12,10 @@ platforms:
     image: ubuntu:latest
 provisioner:
   name: ansible
+  inventory:
+    group_vars:
+      all:
+        cntlm_ignore_docker: no
   lint:
     name: ansible-lint
 scenario:

tasks/main.yml

@@ -83,4 +83,4 @@
     state: started
     enabled: yes
   when:
-    - ansible_virtualization_type != "docker"
+    - ansible_virtualization_type != "docker" or cntlm_ignore_docker