Skip to content

Commit

Permalink
Change yes/no to true/false, adhere to yamlspec 1.2.2
Browse files Browse the repository at this point in the history
  • Loading branch information
robert-de-bock committed Mar 18, 2024
1 parent 2ed7382 commit 0637aef
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/requirements2png.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ jobs:
uses: ad-m/github-push-action@master
with:
directory: ${{ github.repository }}
force: yes
force: true
branch: png
3 changes: 0 additions & 3 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ rules:
line-length: disable
truthy:
check-keys: no
allowed-values:
- "yes"
- "no"

ignore: |
.tox/
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ This example is taken from [`molecule/default/converge.yml`](https://github.com/
---
- name: Converge
hosts: all
become: yes
gather_facts: yes
become: true
gather_facts: true

roles:
- role: robertdebock.docker_ce
Expand All @@ -30,8 +30,8 @@ The machine needs to be prepared. In CI this is done using [`molecule/default/pr
---
- name: Prepare
hosts: all
become: yes
gather_facts: no
become: true
gather_facts: false

roles:
- role: robertdebock.bootstrap
Expand Down
2 changes: 1 addition & 1 deletion handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@

- name: Apt update cache
ansible.builtin.apt:
update_cache: yes
update_cache: true
4 changes: 2 additions & 2 deletions molecule/default/converge.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
- name: Converge
hosts: all
become: yes
gather_facts: yes
become: true
gather_facts: true

roles:
- role: ansible-role-docker_ce
Expand Down
4 changes: 2 additions & 2 deletions molecule/default/prepare.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
- name: Prepare
hosts: all
become: yes
gather_facts: no
become: true
gather_facts: false

roles:
- role: robertdebock.bootstrap
Expand Down
6 changes: 3 additions & 3 deletions molecule/default/verify.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
---
- name: Converge
hosts: all
become: yes
gather_facts: no
become: true
gather_facts: false

tasks:
- name: Check docker group configuration
ansible.builtin.lineinfile:
path: /etc/group
regex: '^docker:x:\d*:woody,buzz$'
state: absent
check_mode: yes
check_mode: true
register: docker_ce_group
changed_when: not docker_ce_group is changed
failed_when: docker_ce_group is changed
Expand Down
2 changes: 1 addition & 1 deletion tasks/assert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
ansible.builtin.assert:
that:
- docker_ce_privileged_users is iterable
quiet: yes
quiet: true
when:
- docker_ce_privileged_users is defined
4 changes: 2 additions & 2 deletions tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
ansible.builtin.user:
name: "{{ user }}"
groups: docker
append: yes
append: true
loop: "{{ docker_ce_privileged_users }}"
loop_control:
loop_var: user
Expand All @@ -55,6 +55,6 @@
ansible.builtin.service:
name: "{{ docker_ce_service }}"
state: started
enabled: yes
enabled: true
when:
- ansible_connection not in [ "container", "docker", "community.docker.docker" ]

0 comments on commit 0637aef

Please sign in to comment.