Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multiple molecule scenarios #5

Closed
till opened this issue Jul 11, 2020 · 13 comments
Closed

Run multiple molecule scenarios #5

till opened this issue Jul 11, 2020 · 13 comments

Comments

@till
Copy link

till commented Jul 11, 2020

Hi,

it seems the action doesn't run all scenarios:
https://github.com/hostwithquantum/ansible-loki/pull/4/checks?check_run_id=860713499

It seems to run default, but not the update scenario.

Is there a way to do a molecule test --all without something like tox? I am not keen on adding another thing. I couldn't figure out how to add parameters to molecule otherwise. Any pointers? I am happy to add the action multiple times too, so I can run the tests in parallel easily.

Till

@till
Copy link
Author

till commented Jul 11, 2020

@robertdebock
Copy link
Owner

Hi @till, you are right, it only runs default now.

Let me see how I can change that.

I think user want the option to be able to specify a name of a scenario, like:

molecule test --scenario-name foo

And have the option to test all:

molecule test --all

so the inputs could be changed to something like this:

## scenarios: Specify the name of a scenario. Defaults to `default`.

Do you think molecule test --all be the default action?

@till
Copy link
Author

till commented Jul 11, 2020

Yeah,good question. I guess --all is a good default?

I like your scenario option/input!

Thanks for taking a look!

@till
Copy link
Author

till commented Jul 13, 2020

@robertdebock I thought about this a bit.

I think with an input for scenario (singular), the --all is not needed.

I think I'd rather use the action multiple times, then having to untangle it. So I can run my scenarios in parallel, for example, or enable only certain scenarios, etc..

If you'd like, I can PR the change?

@robertdebock
Copy link
Owner

Hi @till.

It's ready to be used, can you test version 2.6.0 and let me know if the suits your needs?

Regards, Robert de Bock.

@robertdebock
Copy link
Owner

Closing, but let me know if you need something else. Thanks @till!

@till
Copy link
Author

till commented Jul 15, 2020

Doesn't seem to work, or am I missing something?
hostwithquantum/ansible-loki@d3dcc25#diff-ee0ca3d1e1ab385d3ada60bac977afbcR14-R19

@till
Copy link
Author

till commented Jul 15, 2020

Looks like it's missing here:
https://github.com/robertdebock/molecule-action/blob/ababe15c11e2e33c07bf4e3c95b2e52c1398cc1e/action.yml#L33-L38

@till
Copy link
Author

till commented Jul 15, 2020

@robertdebock I would re-open, but I can't.

@robertdebock
Copy link
Owner

You are correct, missed that, sorry!

@robertdebock robertdebock reopened this Jul 16, 2020
@robertdebock
Copy link
Owner

This should be solved with version 2.6.1. Sorry for the inconvenience, thanks for helping me out!

@till
Copy link
Author

till commented Jul 16, 2020

I'll test when I get back! Thank you!

till added a commit to hostwithquantum/ansible-loki that referenced this issue Jul 16, 2020
@till
Copy link
Author

till commented Jul 16, 2020

Works! :) Thanks again!

@till till closed this as completed Jul 16, 2020
manics pushed a commit to manics-archive/ome-ansible-molecule that referenced this issue Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants