Unicorn makes riders magical #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memcmahon
requested changes
Feb 9, 2021
| end | ||
|
|
||
| def make_magic | ||
| @name = "Yer a wizard #{name}" |
There was a problem hiding this comment.
When we make a rider magic, should we maintain their non-magic name for use in the non-magic world?
| @@ -0,0 +1,23 @@ | |||
| class Unicorn | |||
| attr_accessor :name | |||
There was a problem hiding this comment.
I think this could be an attr_reader - is there a reason that we are exposing this?
Comment on lines
+10
to
+12
| def exclaim_name | ||
| p name.upcase | ||
| end |
There was a problem hiding this comment.
Yes! I love when unicorns can speak!
| end | ||
|
|
||
| def add_rider(rider) | ||
| @riders<< rider |
There was a problem hiding this comment.
Let's put a space here between @riders and <<
| end | ||
|
|
||
| def make_riders_magical | ||
| riders.length.times do |i| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request Do
Gif here
Type of Pull Request
Anything in particular you are requesting from reviewer?
PR Checklist