Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test suite #13

Closed
4brunu opened this issue Nov 12, 2018 · 5 comments
Closed

Add test suite #13

4brunu opened this issue Nov 12, 2018 · 5 comments

Comments

@4brunu
Copy link
Contributor

4brunu commented Nov 12, 2018

I opened this issue, to continue the conversation started in #12 about tests.

Do you want create the Xcode project to add the test target, or should I create it? 馃檪
@roberthein
Copy link
Owner

If you wouldn't mind. 馃檪
Btw, I just release Observable 1.4.0 with all your previous PR's. Thank you so much for all your contributions so far! 馃檹

@4brunu
Copy link
Contributor Author

4brunu commented Nov 12, 2018

Thanks for being so open to external contributions 馃憤
By the way, could you please also release 1.4.0 on Cocoapods?
Thanks

@roberthein
Copy link
Owner

I already did, this afternoon.. maybe run pod update?

@4brunu
Copy link
Contributor Author

4brunu commented Nov 12, 2018 •
edited

You are right 馃檪 The search at Cocoapods.org shows version 1.3.3, but the Podspec file of 1.4.0 is already published. Thanks 馃憤

@4brunu 4brunu mentioned this issue Jan 7, 2020
Merged
@roberthein
Copy link
Owner

Thank you @Edudjr and @4brunu, I just published Observable (2.0.0) successfully. 馃檹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roberthein @4brunu