Add thread safety to Observable.value #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty smart. 😃 But Im AFK now, will look at it tomorrow. |
|
No problem! 🙂 Thanks for all the feedback and approving the other PR today 👍 😄 |
|
Just made some additional changes, UniqueID and Observers should also be thread safe |
|
Very nice! I was just looking at a good way to test this stuff.. let's get this merged ;) |
|
I was thinking that this project could have a test suite. |
|
Great idea again. There could just be a Xcode project living in the root-folder. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #11