Support the topic, and move to EUMM #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added .gitignore and .editorconfig.
Added tests and code
This updates chopped() to have the same capability as chomped() Also, updated Travis config to run on newer Perls, and added Appveyor config
This should take care of robertkrimen#2.
- Text::Chomped delegates to Text::Chomped::From5.014 for Perl >= 5.014 and to Text::Chomped::Pre5014 for Perl < 5.014 - t/02-topic skips all on < 5.014 because Pre5014 can't automatically chop/chomp the target
|
@robertkrimen @ghcraig Any thoughts? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for a useful module! This PR:
choppedandchompedto work on$_if no parameter is given, on Perl 5.14+ (fixes Improved prototype to handle $_ #1).I found the same issue you did with the prototype on Perl < 5.14, so I split the code into the pre-5.14 version and the 5.14+ version. The
use Text::Chompedline is the same either way. All tests pass: Travis.Thank you for considering this PR!