Skip to content

Commit

Permalink
Adjusting the plugin to work with Mahara 17.04
Browse files Browse the repository at this point in the history
Currently you will need to copy the 'casconfig' language line to
lang/en.utf8/admin.php but will hopefully fix later so string can be
in plugin

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
  • Loading branch information
robertlyon777 committed Sep 19, 2017
1 parent bee23b4 commit 7d85fe3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions PluginAuthCas.class.php
Expand Up @@ -206,6 +206,7 @@ public static function get_instance_config_options ($institution, $instance = 0)
'legend' => get_string ('cassettings', 'auth.cas'),
'collapsible' => true,
'collapsed' => true,
'class' => 'last',
'elements' => array(
self::CAS_HOSTNAME => array(
'type' => 'text',
Expand Down Expand Up @@ -298,7 +299,7 @@ public static function get_instance_config_options ($institution, $instance = 0)

return array(
'elements' => $elements,
'renderer' => 'table'
'renderer' => 'div'
);

}
Expand All @@ -311,7 +312,7 @@ public static function get_instance_config_options ($institution, $instance = 0)
* @param unknown_type $form
*/

public static function save_instance_config_options ($values, $form) {
public static function save_instance_config_options ($values, Pieform $form) {
//pp_error_log('values', $values);

// let parent take care of the LDAP settings and of creating the authinstance if needed
Expand Down
2 changes: 1 addition & 1 deletion lang/en.utf8/auth.cas.php
Expand Up @@ -30,7 +30,7 @@
$string['title'] = 'CAS';
$string['description'] = 'Authenticate against a CAS SSO server';
$string['notusable'] = 'You can have only one instance of the CAS authentification plugin';

$string['casconfig'] = 'CAS configuration';
$string['login'] = 'CAS Login';

$string['plugincasnotinstalled'] = 'Your administrator has not install the CAS authentication plugin';
Expand Down

3 comments on commit 7d85fe3

@hersoncruz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robert,
Does CAS/CAS/Client.php need changes to use $SESSION instead of $_SESSION ?
Regards,

@robertlyon777
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I made a merge mistake - the $_SESSION should all be handled correctly as $SESSION now

@hersoncruz
Copy link

@hersoncruz hersoncruz commented on 7d85fe3 Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've trying to debug an issue we have with CAS login, one question comes to mind:
With this new version of Mahara's CAS plugin (for 17.04), is the use of LDAP mandatory? Because it worked perfectly fine for CAS only in Mahara 15.04.

Please sign in to comment.