Re-implement the blob tx parser in a lower-level style #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
parse-fix
branch
6 times, most recently
from
1da40bc
to
2136e4d
Compare
roberto-bayardo
force-pushed
the
parse-fix
branch
4 times, most recently
from
f60f47c
to
e29d808
Compare
…necessary byte copying.
roberto-bayardo
force-pushed
the
parse-fix
branch
from
e29d808
to
24538dd
Compare
0x00101010
reviewed
Jan 18, 2023
| func (s wrapperKzgSequence) At(i int) eth.KZGCommitment { | ||
| kzg := eth.KZGCommitment{} | ||
| if i >= s.num { | ||
| return kzg |
There was a problem hiding this comment.
should we return a reference for the function? this way you can return nil and make it easier for caller to distinguish return?
There was a problem hiding this comment.
this is part of the interface expected by the eth. library in go-kzg -- it's idiomatic in geth code at least to always pass small fixed length arrays like these by value.
0x00101010
reviewed
Jan 18, 2023
| @@ -80,6 +79,28 @@ func NewTxParseContext(chainID uint256.Int) *TxParseContext { | |||
| return ctx | |||
| } | |||
|
|
|||
| // recover sender address after appropriately populating ctx.Sighash, ctx.R & ctx.S | |||
| func (ctx *TxParseContext) RecoverSender(vByte byte, sender []byte) error { | |||
| binary.BigEndian.PutUint64(ctx.Sig[0:8], ctx.R[3]) | |||
There was a problem hiding this comment.
curious about the general encoding choices, I saw both LittleEndian & BigEndian used, is that right?
There was a problem hiding this comment.
Unfortunately yes.. ssz uses the opposite of RLP/legacy encoding.
0x00101010
approved these changes
Jan 18, 2023
roberto-bayardo
added a commit
that referenced
this pull request
Jan 20, 2023
…necessary byte copying. (#7)
roberto-bayardo
added a commit
that referenced
this pull request
Jan 25, 2023
…necessary byte copying. (#7)
roberto-bayardo
added a commit
that referenced
this pull request
Jan 26, 2023
…necessary byte copying. (#7)
roberto-bayardo
added a commit
that referenced
this pull request
Feb 10, 2023
…necessary byte copying. (#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is more consistent with the existing parsing code: it avoids instantiating new objects and instead grabs data directly from the payload buffer as needed.