Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verification to not save polls without choices #23

Merged
merged 1 commit into from
Nov 1, 2017
Merged

add verification to not save polls without choices #23

merged 1 commit into from
Nov 1, 2017

Conversation

nilemarbarcelos
Copy link
Collaborator

Scenario

  • By adding the verification to not include blank choices, we introduced a bug that would save polls without choices, that is no more

Copy link
Owner

@robertoduessmann robertoduessmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great @nilemarbarcelos
Maybe in the future, we can implement a friendly alert to explain to user that he needs insert atleast one option.
Thanks for contribution 🎉

@robertoduessmann robertoduessmann merged commit 6efe919 into robertoduessmann:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants