Add user-agent header to every http request. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New api is running behind CloudFlare which requires user-agent header to be sent. If it isn't, response is always 403 with following error message: `The owner of this website (yts.ag) has banned your access based on your browser's signature`
|
|
||
| public class UserAgentInterceptor implements RequestInterceptor { | ||
|
|
||
| private static final String USER_AGENT = "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.82 Safari/537.36"; |
There was a problem hiding this comment.
I like the approach with the interceptor, but I don't think we should use a browser user agent.
I think we should allow the client of the library to customize this. Maybe something like withUserAgent(String)
I will try a few things during the weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New api #4 is running behind CloudFlare which requires user-agent header to be sent. If it isn't, response is always 403 with following error message:
The owner of this website (yts.ag) has banned your access based on your browser's signature