Add last_cached_at metadata column for existing shards #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertzk @kirillseva |
|
Nice tests man! |
|
thanks @kirillseva |
|
Nice tests |
added 2 commits
January 13, 2016 22:01
| describe("when safe_column is TRUE", { | ||
| test_that('it crashes when trying to expand a table on new column', { | ||
| dbtest::with_test_db({ | ||
| lapply(dbListTables(test_con), function(t) dbRemoveTable(test_con, t)) |
There was a problem hiding this comment.
I don't think you need to do this anymore... @peterhurford ?
There was a problem hiding this comment.
@kirillseva Just did a little test. Tables persist between runs. So this line is still needed.
There was a problem hiding this comment.
No you have to do this using with_test_db. But dbtest::db_test_that would do this automatically.
There was a problem hiding this comment.
@peterhurford oh woah.. Nice! That's really helpful. Thanks for clearing it up.
|
@khalidharun backmerge again |
added 2 commits
January 14, 2016 13:34
|
@kirillseva is there rebuild button for Travis? It hit a github error again. |
|
@robertzk ready to go |
robertzk
added a commit
that referenced
this pull request
Jan 15, 2016
Add last_cached_at metadata column for existing shards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that existing shards that don't have a
last_cached_atcolumn (ie. created before cachemeifyoucan version 0.2.3.4) doesn't work correctly withsafe_columns. That issue is now addressed in this PR.