Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipchat function did not passed api_token to hipchat_send #15

Merged
merged 1 commit into from Jun 14, 2016
Merged

hipchat function did not passed api_token to hipchat_send #15

merged 1 commit into from Jun 14, 2016

Conversation

MarcinKosinski
Copy link
Contributor

No description provided.

@MarcinKosinski
Copy link
Contributor Author

@robertzk was this intended ?

Now passing api_token parameter to hipchat() function does not do anything since hipchat_send takes by default api_token = hipchat_api_token()

So using hipchat(api_token = 'my_own_token') under the hood is actually hipchat(api_token = hipchat_api_token())

@MarcinKosinski
Copy link
Contributor Author

And this means you will no longer have to follow the instruction from README.md

You will need to have a HIPCHAT_API_TOKEN in your environment variables, or set a options(hipchat.api_token = 'your_api_token') in your ~/.Rprofile.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.241% when pulling dbae4b8 on MarcinKosinski:patch-1 into ff23a53 on robertzk:master.

@robertzk robertzk added the bug label Jun 14, 2016
@robertzk
Copy link
Owner

@MarcinKosinski Good point - thanks!

@robertzk robertzk merged commit 28856de into robertzk:master Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants