Accompanying change for s3mpi change to support safe = TRUE/FALSE #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Since running syberia files is a reproducible process there | ||
| # shouldn't be a lot of damage done | ||
| # There is an option to overwrite this behavior | ||
| if (is.element('safe', names(opts))) args$safe <- opts$safe |
There was a problem hiding this comment.
this is the non-trailing-whitespace change
There was a problem hiding this comment.
Why not
args$safe <- opts$safe %||% args$safeThere was a problem hiding this comment.
Just to have the same style in two adjacent lines
if (is.element('safe', names(opts))) args$safe <- opts$safe
if (is.element('s3path', names(opts))) args$.path <- opts$s3path
Should I refactor both before merge?
There was a problem hiding this comment.
Yes please, I don't know what I was thinking.
| @@ -1,7 +1,7 @@ | |||
| Package: syberiaStages | |||
| Type: Package | |||
| Title: Syberia Stages | |||
| Version: 0.2.1 | |||
| Version: 0.3.0 | |||
|
Looks good! |
robertzk
added a commit
that referenced
this pull request
Feb 26, 2015
Accompanying change for s3mpi change to support safe = TRUE/FALSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped the package version so that we can later enforce it using the lockfile