Fix s3data export everyone talks about but no one fixes it #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2015 14:01
| @@ -232,17 +232,15 @@ construct_s3_adapter <- function() { | |||
| write_function <- function(object, opts) { | |||
| common_s3mpi_package_loader() | |||
|
|
|||
| if (is.element('output', names(object))) { | |||
There was a problem hiding this comment.
Just replace names(object) with ls(object) -- ls works for lists and environments, although it does not preserve order (which we don't care about here).
There was a problem hiding this comment.
ls is not recursive and might fail if one if the object in the middle does not exist
and this kind of failture seems to be silent when running syberia (still not sure why)..
|
Changes Unknown when pulling f4707da on fix_s3data_export_everyone_talks_about_but_no_one_fixes_it into * on master*. |
|
Closed with unmerged commits? |
|
@peterhurford we went with a different approach (s/names/ls) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the take away is environment object (aka tundra container) is not an environment and names on it will be null so have to carefully check if object$output$options$data is in, that's why we need bring back name_exists