-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 #56
Comments
Yes, it would be nice not to have to go to a fork or alternate branch for remove functionality. |
You're absolutely right. It's hard to maintain two separate branches. Maybe I should just port the changes from v2 back to master and assume that people use pinned versions or vendoring for anything serious... |
@elgs @shurcooL as frequent contributors, what is your opinion on porting v2 to master and breaking backwards compatibility? Is that worth it for the simplification, or would it just break a ton of users? Right now v2 is invisible and not helping folks as much as it could, and it's a pain to maintain separate versions. |
I myself don't mind breaking the compatibilities. The only thing I need is when a job is created, I need a handle/reference to that job so that at a later time, I can use that handle/reference to do something to that job, mostly stop it and remove it. |
I didn't know If it were up to me, I would do it. Those who care about backwards compatibility and things not breaking unexpectedly will be vendoring this library anyway, so they won't be negatively affected (and if they're not vendoring and feel unhappy, they should be vendoring). For everyone else, they'll get exposed to the latest and most optimal library API by default. And it's less effort and maintenance for you. Those are my generic thoughts. I haven't looked at the differences in the API, so I can't comment on that. |
master is more active than v2, and has some important fix. Hard to tell which branch is better. |
+1, also regular tagged releases would be awesome, glide default to v1 from 2014 |
@robfig do you need any help with porting the v2 stuff on master? I need the remove job feature from v2 but dont want to use non-master branch for a brand new project. I can help with porting bits & pieces. Its gonna break the existing users, but I think thats fair. |
Hi @robfig just chiming in -- I'd like to be able to remove a job (in v2 only), but I also need support for Location -- since testing is damn near impossible for other time zones without being able to run it in a fixed time.Location. Is there another branch that supports both of these features somewhere? |
Does this work help? If this helps most of you guys and reasonably comply with what @elgs and @shurcooL expressed, I'd create a pull request so that my change can be part of robfig's original repo and be maintained. Below are what I did in my repo:
Lastly I appreciate @robfig for creating this package. I especially like how cron.Parse works. |
Thanks @oklahomer -- also very much appreciate @robfig's work here. It looks like a solid little utility. I ended up browsing the fork network and grabbed this derivation as it included the removal, as well as |
Have to agree - been waiting to start a little project of mine, thought I'd wait until delete jobs was merged in from v2. Backwards compatibility could be sacrificed if using semantic versioning (its looking like the official vendor functionality will support this in future). I think there are enough new features and stability fixes as to make breaking compatibility worthwhile to existing users IMHO |
Would be nice to have an additional interface cron methods like Suspend and Resume by EntryID. |
@robfig please give us a v2 release. |
There is now a v3 branch which works with Go Modules, which has all the fixes and updates from both master and v2 branch. I'm still tracking down a couple last bugs and one more upgrade in functionality before calling it done. Feedback is welcome. Thanks |
Hello,
Is v2 still supported ?
Are recent fixes on master planned to be ported to v2 ?
The text was updated successfully, but these errors were encountered: