Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glock save gets confused by build tags #29

Closed
tamird opened this issue Feb 10, 2016 · 1 comment
Closed

glock save gets confused by build tags #29

tamird opened this issue Feb 10, 2016 · 1 comment

Comments

@tamird
Copy link
Contributor

tamird commented Feb 10, 2016

If I have some conditional dependencies (i.e. ones that are defined in files that are build only on e.g. linux), and I run glock save on a system where those conditional dependencies are not required, my GLOCKFILE will not include all possible dependencies of my project.

This has implications when developing on OS X and running CI on linux.

A cursory look at the glock code reveals that we're currently shelling out to go list, which I don't think allows specifying build tags, but we should really be using the go/build package anyway, and specifying the union of (at least) all OS build tags when resolving dependencies.

@bdarnell
Copy link
Contributor

go list does accept -tags', but since+build` directives can be both positive and negative simply specifying the union of all known build tags won't necessarily pick up everything (i'm not sure if it would work in the case we're running into; I haven't pulled on that thread to see where exactly the problematic dependency comes from)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants