Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we merge AssertionContext and ComposedAssertions? #20

Closed
robfletcher opened this issue May 10, 2018 · 2 comments
Closed

Can we merge AssertionContext and ComposedAssertions? #20

robfletcher opened this issue May 10, 2018 · 2 comments
Labels
💥 breaking change Will change APIs in a non-backward compatible way 🤔 question Further information is requested
Milestone
v1.0

Comments

@robfletcher
Copy link
Owner

No description provided.

@robfletcher robfletcher added 🤔 question Further information is requested 💥 breaking change Will change APIs in a non-backward compatible way labels May 10, 2018
@robfletcher
Copy link
Owner Author

Tricky for things like Assertion<Collection<E>>.containsExactly where we do some atomic checks that can pass / fail the whole assertion before running composed checks on elements.

@robfletcher robfletcher added this to the v1.0 milestone May 16, 2018
@robfletcher
Copy link
Owner Author

Pretty much resolved with recent refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💥 breaking change Will change APIs in a non-backward compatible way 🤔 question Further information is requested
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@robfletcher