Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More assertion functions #29

Closed
8 of 10 tasks
robfletcher opened this issue May 15, 2018 · 0 comments
Closed
8 of 10 tasks

More assertion functions #29

robfletcher opened this issue May 15, 2018 · 0 comments
Labels
🦄 enhancement New feature or request 🐣 good first issue Good for newcomers 🆘 help wanted Extra attention is needed
Projects
Release 1.0
Milestone
v1.0

Comments

@robfletcher
Copy link
Owner

robfletcher commented May 15, 2018 •
edited
Loading

Additional assertions should be added to the strikt.assertions package.

Some ideas:

CharSequence

  • contains(String)
  • isNumeric()
  • isEqualToIgnoringCase(String)

Collection

  • map to sub-sequence

Map

  • isEmpty()
  • contains(K, V)
  • containsKey(K)

Data classes / POJOs

  • isIndenticalTo(T) (property-by-property equality)
  • propertyEquals(Any) (shortcut for map(KProperty0).isEqualTo(expected))

Arrays

  • contentEquals(T) (delegate to same method on Kotlin's Array type)
@robfletcher robfletcher added 🦄 enhancement New feature or request 🆘 help wanted Extra attention is needed 🐣 good first issue Good for newcomers labels May 15, 2018
@robfletcher robfletcher added this to the v1.0 milestone May 16, 2018
robfletcher added a commit that referenced this issue May 16, 2018
@robfletcher
Added a few new char sequence assertions
e470951 
Issue #29
robfletcher added a commit that referenced this issue May 16, 2018
@robfletcher
Added Assertion<String>.isEqualToIgnoringCase
b25d8a3 
Issue #29
robfletcher added a commit that referenced this issue May 29, 2018
@robfletcher
Boolean isTrue / isFalse
20c92cf 
Issue #29
robfletcher added a commit that referenced this issue May 29, 2018
@robfletcher
Make isTrue/isFalse work on Boolean?
a782a8b 
Issue #29
robfletcher added a commit that referenced this issue May 29, 2018
@robfletcher
Assertion<Map>.isEmpty
556f913 
Issue #29
@robfletcher robfletcher added this to In progress in Release 1.0 Jul 20, 2018
robfletcher added a commit that referenced this issue Aug 10, 2018
@robfletcher
isEqualTo within tolerance for Double/Float
a3d993e 
Fixes #63
Relevant to #29
Release 1.0 automation moved this from In progress to Done Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🦄 enhancement New feature or request 🐣 good first issue Good for newcomers 🆘 help wanted Extra attention is needed
Projects
Release 1.0
  
Done
Milestone
v1.0
Development

No branches or pull requests
1 participant
@robfletcher