Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved array copy performance #286

Closed
wants to merge 1 commit into from
Closed

Improved array copy performance #286

wants to merge 1 commit into from

Conversation

jisungbin
Copy link

Hi, thanks for creating such a nice library.
I would like to suggest a minor change.

1. Use Array.asList() instead of Array.toList().

As I understand it, Array.toList() copies the array elements and converts them to a List. But Array.asList() wraps the array itself as a List. (No element copying)

2. correct passe to passes

I think you guys meant passes.

If this was your intention, please feel free to close this PR.
Thanks!

@jisungbin jisungbin closed this by deleting the head repository May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant